fix: improve text selection visibility in dark code editor on light theme#5369
Open
ageev wants to merge 1 commit intoNginxProxyManager:developfrom
Open
fix: improve text selection visibility in dark code editor on light theme#5369ageev wants to merge 1 commit intoNginxProxyManager:developfrom
ageev wants to merge 1 commit intoNginxProxyManager:developfrom
Conversation
…heme When using the light theme, text selected in the Custom Nginx Configuration editor (and other dark-themed code editors) was nearly invisible because the browser's light-mode selection color blended with the dark editor background. This adds an explicit ::selection style for the editor textarea that provides sufficient contrast on the dark background. The fix applies to all five components using the dark code editor: NginxConfigField, LocationsFields, DNSProviderFields, EventDetailsModal, and DefaultSite.
ageev
force-pushed
the
fix/light-theme-editor-selection-visibility
branch
from
c5dd06d to
255d894
Compare
|
Docker Image for build 2 is available on DockerHub: Note Ensure you backup your NPM instance before testing this image! Especially if there are database changes. Warning Changes and additions to DNS Providers require verification by at least 2 members of the community! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
::selectioncolor blends with the dark editor background::selectionstyle (#264f78) for the.w-tc-editor-texttextarea whendata-bs-theme="light"is activeNginxConfigField,LocationsFields,DNSProviderFields,EventDetailsModal, andDefaultSiteRoot cause
The code editor (
@uiw/react-textarea-code-editor) usesdata-color-mode="dark"to force a dark background, but the app'scolor-scheme: lightCSS property (set inApp.cssfor the light theme) causes the browser to use light-mode default selection colors. This results in light-colored selection highlights on a dark background with light text — making selections invisible.Test plan